Feature/v2 upgrade #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…temDefinitionBase classes For something like a card with a lot of file logic behind it, the name of the card can be safely hard coded. ItemDefinitionBase no longer contains a serialized implementation of string _displayName so you'll have to implement it BREAKING CHANGE: Find all classes that inherit ItemDefinitionBase and add `[SerializeField] string _displayName; public override string DisplayName => _displayName;`. To fix the error that your classes do not implement the display name get accessor.
You must have a field called _category to detect live changes in the window via dynamic binding. Not required if you don't want live binding support to serialized changes. close #21
Using ItemEntryData to pass in items to InventoryInstance.AddEntry would crash due to an edge case where it thought the read only item could be runtime manipulated. fix #17
… item entry type Was crashing due to a failed LINQ cast that sometimes silently failed. fix #20
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2025
Feature/v2 upgrade
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.