Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform/processingLevel concept-id aliasing, DATASET Constants, constants no longer top level imports #238

Merged
merged 22 commits into from
Jan 24, 2024

Conversation

SpicyGarlicAlbacoreRoll
Copy link
Contributor

@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll commented Nov 15, 2023

Changed

  • Constants are no longer top level import, are now accessible through respective modules
  • search keywords processingLevel and platform are now aliased by collection concept-ids when available, improving performance and potentially dodging param splitting subquery system (lists of concept ids by their processing levels/platforms viewable in dataset.py).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1efbbe0) 89.98% compared to head (927d621) 90.06%.

Files Patch % Lines
asf_search/search/search_generator.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   89.98%   90.06%   +0.08%     
==========================================
  Files          54       54              
  Lines        2046     2073      +27     
==========================================
+ Hits         1841     1867      +26     
- Misses        205      206       +1     
Flag Coverage Δ
unittests 90.06% <98.59%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll changed the title DATASET Constants, constants no longer top level imports platform/processingLevel concept-id aliasing, DATASET Constants, constants no longer top level imports Nov 17, 2023
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll merged commit 2bf6b21 into master Jan 24, 2024
3 checks passed
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll deleted the topic-dataset-constants branch January 24, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants