Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S1 Baseline Stacking Fix #236

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

SpicyGarlicAlbacoreRoll
Copy link
Contributor

Inconsistency between datetime.timestamp() across systems causes timestamp() to infer different timezones for date objects. Baseline calculations depends on these values, and when certain product baseline values lacked the timezone indicator it'd lead to bad baseline values depending on the system environment.

Solution:

  • appends 'Z' to S1 baseline date properties if missing (ascending node time, sv times, etc)

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f9ff0b) 89.83% compared to head (0dfa6df) 89.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   89.83%   89.86%   +0.03%     
==========================================
  Files          53       53              
  Lines        1987     1994       +7     
==========================================
+ Hits         1785     1792       +7     
  Misses        202      202              
Flag Coverage Δ
unittests 89.86% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll merged commit ce8d91c into master Nov 15, 2023
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll deleted the bugfix-s1-stacking-timezone branch November 15, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants