ASFProduct Subclassing #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 89.79% 89.73% -0.06%
==========================================
Files 54 69 +15
Lines 2028 2299 +271
==========================================
+ Hits 1821 2063 +242
- Misses 207 236 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 11 commits
December 6, 2023 11:44
added 2 commits
January 12, 2024 13:45
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
added 8 commits
January 16, 2024 08:40
…classing-product-casting
…one methods in baseline_search module
williamh890
reviewed
Jan 17, 2024
| _base_properties dictionary, mapping readable property names to paths and optional type casting | ||
|
|
||
| entries are organized as such: | ||
| - `PROPERTY_NAME`: The name the property should be called in `ASFProduct.properties` |
There was a problem hiding this comment.
Possible to use an object for this instead of a dictionary
added 2 commits
January 17, 2024 16:43
…ffNadirAngle for all but ALOS products
…classing-product-casting
…classing-product-casting
…pdate example notebook
williamh890
approved these changes
Jan 24, 2024
…oduct-casting Adds subproduct class type casting to baseline_search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks platform/processing level specific fields and aliases into subclasses, removes several non-common fields from base
ASFProductclass.get_stack_opts()method intoASFProductfor subclasses to overrideUMMFieldsmodule for common UMM property paths and aliasesBaselineCalcTypeenum class toASFProduct, used to define perpendicular baseline calculation behavior for subclasses