-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Windows tests on GitHub Actions #679
Conversation
The tests still fails, but it has nothing to do with this PR. |
and after merging this PR, we will need to be removed appveyor integration from the organization settings. |
Yep, those appveyor builds have been always failing, I'm ok with removing them (or perhaps making the windows part of the workflow optional). Perhaps someday, someone with access to windows can help us get those test pass. |
I changed config to ignore the tests failure on Windows. |
ebf091b
to
560ee6b
Compare
Okay, maybe this is ready for review now. |
Oh, I really don't like yaml and the editor that can't handle it well. |
Thanks 👍 |
👍 |
FYI @abhishalya, this MR removes the appveyor build introduced in #450 since we are now able to test on all platforms with github actions. Test were never successful on windows since #450 was merged some months ago. Windows tests are run now, but being ignored til someone really finds the motivation to get them passing. @HashNuke, @Stratus3D we need to disable the appveyor integration in this repo (I dont have access to such settings), could anyone do that, please? |
There is probably an appveyor item somewhere in these links, and deleting it should solve the problem. |
Thanks @imbsky. I just uninstalled AppVeyor. |
👍 |
No description provided.