Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Windows tests on GitHub Actions #679

Merged
merged 1 commit into from
Mar 15, 2020
Merged

Conversation

smorimoto
Copy link
Member

No description provided.

@smorimoto
Copy link
Member Author

The tests still fails, but it has nothing to do with this PR.

@smorimoto
Copy link
Member Author

and after merging this PR, we will need to be removed appveyor integration from the organization settings.

@vic
Copy link
Contributor

vic commented Mar 15, 2020

Yep, those appveyor builds have been always failing, I'm ok with removing them (or perhaps making the windows part of the workflow optional).

Perhaps someday, someone with access to windows can help us get those test pass.

@smorimoto
Copy link
Member Author

I changed config to ignore the tests failure on Windows.

@smorimoto smorimoto force-pushed the actions-win branch 4 times, most recently from ebf091b to 560ee6b Compare March 15, 2020 04:18
@smorimoto
Copy link
Member Author

Okay, maybe this is ready for review now.

@smorimoto
Copy link
Member Author

Oh, I really don't like yaml and the editor that can't handle it well.

@vic
Copy link
Contributor

vic commented Mar 15, 2020

Thanks 👍

@vic vic merged commit cdb39ca into asdf-vm:master Mar 15, 2020
@smorimoto smorimoto deleted the actions-win branch March 15, 2020 05:02
@smorimoto
Copy link
Member Author

👍

@vic
Copy link
Contributor

vic commented Mar 15, 2020

FYI @abhishalya, this MR removes the appveyor build introduced in #450 since we are now able to test on all platforms with github actions. Test were never successful on windows since #450 was merged some months ago.

Windows tests are run now, but being ignored til someone really finds the motivation to get them passing.

@HashNuke, @Stratus3D we need to disable the appveyor integration in this repo (I dont have access to such settings), could anyone do that, please?

@smorimoto
Copy link
Member Author

@abhishalya
Copy link
Contributor

@vic Thanks for updating me. @jayvdb maybe you want to look into this?

@Stratus3D
Copy link
Member

Thanks @imbsky. I just uninstalled AppVeyor.

@smorimoto
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants