Allow parsing required_version using constraints #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds functionality to allow parsing the `required_version` directly from the `.tf` file. This allows for fully configuring the terraform version via the official terraform version management syntax. The logic was codified from the [Terraform Docs on Version Constraints](https://www.terraform.io/language/expressions/version-constraints).
hoshsadiq
commented
Aug 14, 2022
Comment on lines
+238
to
+240
| # todo doing this on every dir change is expensive. What is a good alternative? | ||
| local all_versions | ||
| IFS=" " read -r -a all_versions <<<"$("${__dirname}/list-all")" |
There was a problem hiding this comment.
Not really sure what the best approach is here. This is pretty expensive to do every single time since it's a network request. Also, in case there is no network, this will most definitely fail.
Perhaps what should be done here is only check local versions if offline (though, how do we check if a user is offline)? And when they are online, perhaps, we can cache the results when list-all is run.
Any thoughts?
|
In addition, I think it would be good if I can get some people to try and break it, to see if any bugs might crop up. |
|
I'm also stuck with the same issue. I'd like it to be merged, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds functionality to allow parsing the
required_versiondirectly from the
.tffile. This allows for fully configuring theterraform version via the official terraform version management syntax.
The logic was codified from the Terraform Docs on Version
Constraints.