fix: link replacement for arm architecture #56

azmelanar · 2022-08-08T11:31:12Z

All links for ARM architecture contains arm64 in filename that cannot download and install application properly:

❯ uname -m
arm64

❯ asdf install
curl: (28) Operation timed out after 90004 milliseconds with 13000157 out of 19758608 bytes received
Downloading terraform version 1.2.2 from https://releases.hashicorp.com/terraform/1.2.2/terraform_1.2.2_darwin_arm.zip
curl: (22) The requested URL returned error: 404
Error: terraform version 1.2.2 not found

With this fix:

❯ asdf install
Downloading terraform version 1.2.2 from https://releases.hashicorp.com/terraform/1.2.2/terraform_1.2.2_darwin_arm64.zip
Verifying signatures and checksums
gpg: keybox '/var/folders/n8/r74pjhw110158k29htt871h80000gn/T/asdf_terraform_XXXXXX.eWvTD5Rv/pubring.kbx' created
gpg: /var/folders/n8/r74pjhw110158k29htt871h80000gn/T/asdf_terraform_XXXXXX.eWvTD5Rv/trustdb.gpg: trustdb created
gpg: key 34365D9472D7468F: public key "HashiCorp Security (hashicorp.com/security) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Wed Jun  1 18:50:16 2022 CEST
gpg:                using RSA key 374EC75B485913604A831CC7C820C6D5CD27AB87
gpg: Good signature from "HashiCorp Security (hashicorp.com/security) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: C874 011F 0AB4 0511 0D02  1055 3436 5D94 72D7 468F
     Subkey fingerprint: 374E C75B 4859 1360 4A83  1CC7 C820 C6D5 CD27 AB87
terraform_1.2.2_darwin_arm64.zip: OK
Cleaning terraform previous binaries
Creating terraform bin directory
Extracting terraform archive

Checked file naming for:

smorimoto · 2023-07-18T16:47:26Z

bin/install

- else
- echo "https://releases.hashicorp.com/${toolname}/${version}/${filename}"
- fi
+ echo "https://releases.hashicorp.com/${toolname}/${version}/${filename}"


Suggested change

echo "https://releases.hashicorp.com/${toolname}/${version}/${filename}"

echo "${releases_host}/${toolname}/${version}/${filename}"

azmelanar requested a review from a team as a code owner August 8, 2022 11:31

fix: link replacement for arm architecture

fad30d7

smorimoto force-pushed the 20220808-install_arm64_arch branch from 00953dc to fad30d7 Compare July 18, 2023 16:44

smorimoto reviewed Jul 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: link replacement for arm architecture #56

fix: link replacement for arm architecture #56

azmelanar commented Aug 8, 2022

smorimoto Jul 18, 2023

	echo "https://releases.hashicorp.com/${toolname}/${version}/${filename}"
	echo "${releases_host}/${toolname}/${version}/${filename}"

fix: link replacement for arm architecture #56

Are you sure you want to change the base?

fix: link replacement for arm architecture #56

Conversation

azmelanar commented Aug 8, 2022

smorimoto Jul 18, 2023

Choose a reason for hiding this comment