Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a type-system inconsistency in the LLVM IR builder regarding string handling.
Previously, a STRING_TYPE was defined as a struct { i32, i8* }, but all actual string operations (concatenation, comparison, casts, puts, function arguments/returns) were already using plain i8*. This created a mismatch between the declared string type and the real IR being generated.
This PR removes the unused struct-based string type entirely and standardizes string representation across the entire IR builder to i8* (C-style null-terminated char pointer), which matches how the codebase already operates.
No behavior or logic was changed — only type consistency was fixed.