Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smartlog) smartlog does not panic when run in a non-git directory #1097

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cshinaver
Copy link

Closes #1069

First time contributing! tackling one of the smaller issues before I look into something more major.

Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cshinaver, thanks for the PR! As written, this would only handle the panic for the case of git branchless smartlog, and only when failing to open the Repo. I would prefer to see an approach that can handle more panics. The best approach overall might be to replace EyreExitOr with an enum something like this:

enum CommandResult<T> {
    Ok(T),
    Exit { exit_code: isize, message: String },
    Unhandled(eyre::Error),
}

Then we could update the try_exit_code! macro (or create a new macro) that can wrap the result of Repo::from_dir and produce a CommandResult::Exit instead of letting the error propagate normally; and update do_main_and_drop_locals to handle the CommandResult and print the error message from the wrapped function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on git branchless init in a non-git directory
2 participants