Add tests and fixes for get/set max rgb value behaviour #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move tests around
update the get_color tests to use the blinkstick fixture
make the blinkstick fixture return a callable that will make a blinkstick, so that we can use it to creat multiple instances in the same test.
Add tests for max_rgb_value to ensure: * that it is per-instance and not class based * that it performs bounds checking when setting * that it performs type checking and coercion when setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
BlinkStickclass, including type annotations, improved bounds checking, and additional tests to ensure the functionality of new and existing features. The most important changes are:Enhancements to
BlinkStickclass:max_rgb_valueattribute and relevant methods insrc/blinkstick/blinkstick.py. [1] [2]set_max_rgb_valuemethod.Improvements in testing:
make_blinkstickfor creatingBlinkStickinstances, ensuring consistency and reducing code duplication. [1] [2]tests/test_blinkstick.pyafter refactoring.