Device major version variant #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 7 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- src/blinkstick/init.py: Evaluated as low risk
- src/blinkstick/backends/base.py: Evaluated as low risk
- src/blinkstick/backends/unix_like.py: Evaluated as low risk
- src/blinkstick/clients/blinkstick.py: Evaluated as low risk
- src/blinkstick/constants.py: Evaluated as low risk
- tests/devices/test_blinkstick_device.py: Evaluated as low risk
- src/blinkstick/enums.py: Evaluated as low risk
- src/blinkstick/models.py: Evaluated as low risk
Rename BlinkStickVariant.identify() to .from_version_attrs(), for added clarity.
Add a serial number model so that it's easier to decompose th estring into constituent parts
robberwick
force-pushed
the
device-major-version-variant
branch
from
fc3f52c to
7e5837e
Compare
robberwick
force-pushed
the
device-major-version-variant
branch
from
7e5837e to
1aa1b0f
Compare
There was a problem hiding this comment.
Copilot reviewed 7 out of 16 changed files in this pull request and generated no suggestions.
Files not reviewed (9)
- src/blinkstick/enums.py: Evaluated as low risk
- tests/devices/test_blinkstick_device.py: Evaluated as low risk
- tests/clients/test_blinkstick.py: Evaluated as low risk
- src/blinkstick/models.py: Evaluated as low risk
- src/blinkstick/init.py: Evaluated as low risk
- src/blinkstick/backends/win32.py: Evaluated as low risk
- src/blinkstick/backends/unix_like.py: Evaluated as low risk
- src/blinkstick/clients/blinkstick.py: Evaluated as low risk
- src/scripts/main.py: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the BlinkStick library, focusing on refactoring the handling of BlinkStick variants and improving the device initialization process. The most important changes include moving
BlinkStickVariantto a newenumsmodule, updating theBlinkStickDeviceclass to useSerialDetails, and adding new methods and tests to support these updates.Refactoring and code organization:
src/blinkstick/__init__.py,src/blinkstick/clients/blinkstick.py,src/scripts/main.py,tests/clients/test_blinkstick.py: Updated imports to reflect the new location ofBlinkStickVariantin theenumsmodule. [1] [2] [3] [4]Device initialization and variant handling:
src/blinkstick/backends/base.py,src/blinkstick/backends/unix_like.py,src/blinkstick/backends/win32.py: Refactored backend classes to useSerialDetailsfor serial number handling and updated methods to reflect this change. [1] [2] [3]src/blinkstick/devices/device.py: UpdatedBlinkStickDeviceclass to includemajor_versionandvariantfields, and added a__post_init__method to set the variant usingSerialDetails.New methods and tests:
src/blinkstick/backends/base.py,src/blinkstick/clients/blinkstick.py: Addedget_variantmethod to backends and updated theget_variantmethod inBlinkStickclass to use the backend method. [1] [2]tests/devices/test_blinkstick_device.py,tests/models/serial_number.py: Added tests for the newSerialDetailsclass and updated tests forBlinkStickDeviceto verify correct initialization and variant handling. [1] [2]