pass correct data type to remap_rgb_value and remap_rgb_value_reverse
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass a tuple, not a list when calling `remap_rgb_value` and `remap_rgb_value_reverse`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/blinkstick/blinkstick.pyfile to improve the handling of RGB values. The most important changes involve modifying the data structures used in theremap_rgb_valueandremap_rgb_value_reversefunctions.Improvements to RGB value handling:
src/blinkstick/blinkstick.py: Changed the input parameter from a list to a tuple in the_determine_rgbmethod to improve the handling of RGB values.src/blinkstick/blinkstick.py: Changed the input parameter from a list to a tuple in themorphmethod to ensure consistency and proper handling of RGB values.