Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport file_renamed_alert::old_name() to RC_1_2 branch #7559

Open
wants to merge 1 commit into
base: RC_1_2
Choose a base branch
from

Conversation

glassez
Copy link
Contributor

@glassez glassez commented Nov 19, 2023

No description provided.

@arvidn
Copy link
Owner

arvidn commented Dec 26, 2023

I'm pretty sure this will break the ABI. i.e. a client built against this patch will break when linked against the current 1.2.x library, and vice versa

@glassez
Copy link
Contributor Author

glassez commented Dec 29, 2023

a client built against this patch will break when linked against the current 1.2.x library

Isn't it expected that an application using some new features of library is incompatible with a previous version of the library that does not have these features (unless it specifically takes care of compatibility with previous versions of the library by conditionally disabling support for these features)?

vice versa

I think we should only talk about the opposite case, when the updated library remains compatible with applications linked to its previous versions. So what exactly do you think could break existing applications? It doesn't change existing thing and just something new.

@glassez
Copy link
Contributor Author

glassez commented Dec 29, 2023

BTW, as for ABI compatibility.
It seems that we have come across some gap in the existing preconditions, which may negate all your efforts about it. Judging by some recent Issues with qBittorrent binaries distributed via some Linux distros, a simple rebuild of the same libtorrent version using a different Boost version can lead to an ABI compatibility break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants