Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: addTag check #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wengeezhang
Copy link

No description provided.

@@ -67,7 +67,7 @@ export function addTag(tag: string, target: any) {
tags = [];
Reflect.defineMetadata(CLASS_TAG, tags, target);
}
tags.push(tag);
!tags.includes(tag) && tags.push(tag);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重复添加 tag 现在造成了什么问题

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后续handleTag不是多循环了一次?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants