fix: Update FilterSelect items when props change #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzucconi
reviewed
Aug 29, 2023
dzucconi
reviewed
Aug 29, 2023
| contextValue.setItems(props.items) | ||
| } | ||
| }, [props.items, contextValue]) | ||
|
|
There was a problem hiding this comment.
I wonder if most of this stuff could just be taken out of state and computed in useMemos
dzucconi
approved these changes
Aug 29, 2023
olerichter00
force-pushed
the
olerichter00/ONYX-240/update-filterselect-items-when-props-change
branch
from
dfd5460 to
61170b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ONYX-240
Description
Update FilterSelect items when props change.