Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(dia-1117): update grid on gallery curated sort for gallery shows #15295

Merged

Conversation

dzucconi
Copy link
Member

@dzucconi dzucconi commented Mar 13, 2025

This PR enables flat grid layouts for artwork displays on show pages so that the curated sort is intuitively reflected. The artwork grid implementation has been refactored to decouple the layout logic from auction-specific checks, making it more flexible for use across different contexts and collection types.

@dzucconi dzucconi requested a review from a team March 13, 2025 14:13
@dzucconi dzucconi self-assigned this Mar 13, 2025
Copy link

relativeci bot commented Mar 13, 2025

#2022 Bundle Size — 8.7MiB (~+0.01%).

f1fd16b(current) vs 5d82a7c main#2020(baseline)

Warning

Bundle contains 18 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#2022
     Baseline
#2020
Regression  Initial JS 3.55MiB(+0.03%) 3.55MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 47.62% 43.21%
No change  Chunks 101 101
No change  Assets 104 104
Change  Modules 5719(-0.02%) 5720
No change  Duplicate Modules 514 514
No change  Duplicate Code 4.03% 4.03%
No change  Packages 269 269
No change  Duplicate Packages 17 17
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2022
     Baseline
#2020
Regression  JS 8.56MiB (~+0.01%) 8.56MiB
No change  Other 141.62KiB 141.62KiB

Bundle analysis reportBranch DIA-1117-update-grid-on-gallery-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@dzucconi dzucconi force-pushed the DIA-1117-update-grid-on-gallery-curated-sort-for-gallery-shows branch from 075bc9f to f1fd16b Compare March 13, 2025 14:23
Copy link
Contributor

@joeyAghion joeyAghion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dzucconi dzucconi merged commit 7b4ca6c into main Mar 13, 2025
11 checks passed
@dzucconi dzucconi deleted the DIA-1117-update-grid-on-gallery-curated-sort-for-gallery-shows branch March 13, 2025 14:53
@artsy-peril artsy-peril bot mentioned this pull request Mar 13, 2025
Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better than isAuction

@anandaroop
Copy link
Member

Hooray 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants