This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Probably better fix for conda s3 bug #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it reads from Stream.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actioncall must be in async, since it uses blockingread()on the provided Stream.In the
conda-adapteraction is executed bycom.artipie.conda.asto.AstoMergedJsonwhich doesread()in json parser from the same thread as data producer, and the deadlock happens.Also added explicit
close()for both streams after they being used. This doesn't seem to be the cause of the bug, but should make behavior more predictable/stable, since AWS SDK has limits on simultaneous connections count in pool.Part of artipie/artipie#1343.