Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add art19 revision number and publishing instructions #5

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

tatthurs
Copy link

@tatthurs tatthurs commented Jun 17, 2024

Add instructions for gem publishing. I added a revision number to the version and instructions for publishing.

Here is the published gem: https://github.com/orgs/art19/packages/rubygems/package/jsonapi.rb

@tatthurs tatthurs force-pushed the tatthurs/art19-revision branch from 7188882 to 80fd1c5 Compare June 17, 2024 23:56
@tatthurs tatthurs force-pushed the tatthurs/art19-revision branch 6 times, most recently from 7ed0856 to 7ec238c Compare July 2, 2024 20:43
@tatthurs tatthurs force-pushed the tatthurs/art19-revision branch 3 times, most recently from 090e64e to cb3f58b Compare July 16, 2024 20:55
@tatthurs tatthurs force-pushed the tatthurs/art19-revision branch from cb3f58b to d10ef23 Compare July 16, 2024 21:06
@@ -175,7 +175,10 @@
let(:user_id) { nil }
let(:note_id) { 'tada' }

it do
# TODO: This spec passes locally but fails under CI. Get this spec
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"works on my box" smh

Copy link

@rortian rortian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Show resolved Hide resolved
@tatthurs tatthurs merged commit fd08ace into master Jul 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants