Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you change the
value
prop to a blank string, Datetime.getSelectedDate() tries to parse the value using the formatstring. This fails for blank values, and then getSelectedDate() falls back to the previously entered input value from this.state.inputValue, ignoring the new
value
prop and making the reset fail.Closes #760.
Motivation and Context
Checklist
I have tested that the fix works manually, by modifying the playground like this
I have attempted to write a unit test, but failed miserably. Here's my attempt:
The test fails with
and I can't get the form control to render anything other than
no matter how I mangle the
renderInput()
code insrc/DateTime.js
. I'm probably missing something stupid, like not runningnpm build
prior tonpm test
.Uhh. That was it.
Please advise: the README says
There's no need to create a new build for each pull request
, but if I don't do that, the new test fails. What should I do?