Added features and a bug fix from https://github.com/arnaucube/babyjubjub-rs/issues/7 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…...better fix might be to force mul_scalar to only accept a BigUInt or to allow the logic in mul_scalar to work with a negative BigInt
|
Hi, just wanted to comment that I have this PR pending to check, but I'm not finding the needed time slot (as it introduces several new things that need time to be checked), but I'm not forgetting about it. Thanks a lot for the PR |
|
Awesome. Incidentally, I've been working on it a bit today so there is a new push with some pretty minor changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged the changes mentioned in #7 for more
Pointfunctions, ElGamal encryption/decryption, DLEQ proofs, (unoptimized) serialization/deserialization, a newFlstruct, and a bug fix.Note: There is one planned change in that issue I did not make: preventing
mul_scalarfrom accepting negative inputs. I imagine this is not unique tomul_scalar, so a better solution would be to replace all instances ofBigInttoBigUintexcept when negative numbers are needed. There seem to be some places negative numbers are needed, and I wanted to be conservative by not changing them. Thus, refactoringBigIntusage toBigUintusage became a bit hairy and I opted not to make that change out of concern with potentially breaking some functionality.