Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add support for using MLSumcheck as subprotocol #73

Merged
merged 3 commits into from
May 23, 2023

Conversation

JayWhite2357
Copy link
Contributor

@JayWhite2357 JayWhite2357 commented Apr 26, 2023

Description

Some protocols use sumcheck as a subprotocol. Two components in MLSumcheck that don't enable this well are:

This PR adds prove_as_subprotocol and verify_as_subprotocol functions to MLSumcheck. As a result, this is not a breaking change. (Although I don't see the utility of the existing verify and prove functions.)

Note: I did not use Sponge since it's on 0.3.0, and seems to be a WIP.

Finally, some tests around this are added/improved.

closes: #64


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@JayWhite2357 JayWhite2357 marked this pull request as ready for review April 26, 2023 01:17
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Pratyush Pratyush merged commit 53244d0 into arkworks-rs:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return of MLSumcheck::prove
2 participants