Set PairingOutput::default()
= TargetField::one()
#694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
PairingOutput<P>::default()
was set toP::TargetField::zero()
. This is clearly incorrect, since 0 is not in the multiplicative subgroup thatPairingOutput
represents. This concretely lead to an unexpected error in arkworks-rs/ripp#50.This PR sets the default value to
P::TargetField::one()
. I don't think you have to treat this as a breaking change. It is very unlikely that someone was using this behavior successfully, since if you multiply (Add
) this value with any otherPairingOutput
, you get 0.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer