Add rule to editorconfig for parity with CONTRIBUTING.md #1524
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is there any difference or maybe an advantage over using clang-format? I have an ongoing effort at #1146 for that. It would include rules on brace placement and much more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CONTRIBUTING.md, there is a line that reads:
- Opening curly braces { at the end of the same line as the statement/condition.Along with the other two rules which are defined (4-space-wide tabs, not spaces), the .editorconfig should now match the requirements.
In the future, I think more rules should be added to the editorconfig file, since if I were to format the code it would likely look very different to if somebody else formatted the code. This leads to every source file being a big mix of different styles and since it is not proper etiquette to make a PR for just formatting, the current mess will stick.