Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont dump sql of virtual fields #17

Merged
merged 3 commits into from
Sep 25, 2024
Merged

dont dump sql of virtual fields #17

merged 3 commits into from
Sep 25, 2024

Conversation

ronenlu
Copy link
Member

@ronenlu ronenlu commented Sep 25, 2024

fix: #16

@@ -16,7 +16,7 @@ CREATE TABLE [RecipeIngredients] (
[createdAt] datetimeoffset(7) NOT NULL,
[updatedAt] datetimeoffset(7) NOT NULL,
[deletedAt] datetimeoffset(7) NULL,
CONSTRAINT [PK_RecipeIngredients] PRIMARY KEY CLUSTERED ([ingredientId] ASC)
CONSTRAINT [PK_RecipeIngredients] PRIMARY KEY CLUSTERED ([recipeId] ASC, [ingredientId] ASC)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR, something changed in atlas

@ronenlu ronenlu requested a review from a8m September 25, 2024 10:22
@ronenlu ronenlu merged commit 2cc78e2 into master Sep 25, 2024
11 checks passed
@a8m a8m deleted the virtual_type branch September 25, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a sequelize model with a Datatype as VIRTUAL a migration is attempted
2 participants