Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added README and atlas.hcl example #9

Merged
merged 3 commits into from
Nov 22, 2023
Merged

docs: added README and atlas.hcl example #9

merged 3 commits into from
Nov 22, 2023

Conversation

dorav
Copy link
Collaborator

@dorav dorav commented Nov 21, 2023

No description provided.

@dorav dorav requested a review from rotemtam November 21, 2023 13:39
@dorav dorav changed the title docs: Added README and atlas.hcl example docs: added README and atlas.hcl example Nov 21, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
}
}
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the env://src issue is fixed, I think you can add the inspection as a sanity check.

Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM see comment about re-adding inspect.

README.md Outdated Show resolved Hide resolved
@dorav dorav merged commit 999deda into master Nov 22, 2023
1 check passed
@dorav dorav deleted the dorav/add_readme branch November 22, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants