Skip to content

Commit

Permalink
Fix dropdown line not shown when horizontal in dictionary dialog
Browse files Browse the repository at this point in the history
  • Loading branch information
arianneorpilla committed May 29, 2023
1 parent 5a0fafa commit 984f1e8
Showing 1 changed file with 27 additions and 11 deletions.
38 changes: 27 additions & 11 deletions yuuna/lib/src/pages/implementations/dictionary_dialog_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -542,17 +542,33 @@ class _DictionaryDialogPageState extends BasePageState with ChangeNotifier {
),
),
),
ChangeNotifierBuilder(
notifier: _formatNotifier,
builder: (_, __, ___) => JidoujishoDropdown<DictionaryFormat>(
options: appModel.dictionaryFormats.values.toList(),
initialOption: appModel.lastSelectedDictionaryFormat,
generateLabel: (format) => format.name,
onChanged: (format) {
appModel.setLastSelectedDictionaryFormat(format!);
_formatNotifier.notifyListeners();
},
),
Stack(
alignment: Alignment.bottomCenter,
children: [
ChangeNotifierBuilder(
notifier: _formatNotifier,
builder: (_, __, ___) => JidoujishoDropdown<DictionaryFormat>(
options: appModel.dictionaryFormats.values.toList(),
initialOption: appModel.lastSelectedDictionaryFormat,
generateLabel: (format) => format.name,
onChanged: (format) {
appModel.setLastSelectedDictionaryFormat(format!);
_formatNotifier.notifyListeners();
},
),
),
Container(
margin: const EdgeInsets.symmetric(vertical: 8),
decoration: BoxDecoration(
border: Border.fromBorderSide(
BorderSide(
width: 0.5,
color: Theme.of(context).unselectedWidgetColor,
),
),
),
),
],
),
],
);
Expand Down

0 comments on commit 984f1e8

Please sign in to comment.