Skip to content

feat: Renaming sessions in the session_list does not immediately close the session_list dialogue and instead returns focus to the dialogue. #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ariane-emory wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

feat: Renaming sessions in the session_list does not immediately close the session_list dialogue and instead returns focus to the dialogue. #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b0c207
feat(tui): return to session list after renaming session
ariane-emory Feb 19, 2026
905d5e3
Merge branch 'dev' into feature/renaming-doesnt-close-session-list
ariane-emory Feb 19, 2026
b3d5142
Merge dev into feature/renaming-doesnt-close-session-list
ariane-emory Feb 20, 2026
0b52656
Merge branch 'dev' into feature/renaming-doesnt-close-session-list
ariane-emory Feb 20, 2026
aee072f
Merge branch 'dev' into feature/renaming-doesnt-close-session-list
ariane-emory Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/opencode/src/cli/cmd/tui/component/dialog-session-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { useKV } from "../context/kv"
import { createDebouncedSignal } from "../util/signal"
import { Spinner } from "./spinner"

export function DialogSessionList() {
export function DialogSessionList(props: { initialSessionID?: string } = {}) {
const dialog = useDialog()
const route = useRoute()
const sync = useSync()
Expand All @@ -30,7 +30,7 @@ export function DialogSessionList() {
return result.data ?? []
})

const currentSessionID = createMemo(() => (route.data.type === "session" ? route.data.sessionID : undefined))
const currentSessionID = createMemo(() => props.initialSessionID ?? (route.data.type === "session" ? route.data.sessionID : undefined))

const sessions = createMemo(() => searchResults() ?? sync.data.session)

Expand Down Expand Up @@ -99,7 +99,8 @@ export function DialogSessionList() {
keybind: keybind.all.session_rename?.[0],
title: "rename",
onTrigger: async (option) => {
dialog.replace(() => <DialogSessionRename session={option.value} />)
const back = () => dialog.replace(() => <DialogSessionList initialSessionID={option.value} />)
dialog.replace(() => <DialogSessionRename session={option.value} onSuccess={back} onCancel={back} />)
},
},
]}
Expand Down
14 changes: 10 additions & 4 deletions packages/opencode/src/cli/cmd/tui/component/dialog-session-rename.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { useSDK } from "../context/sdk"

interface DialogSessionRenameProps {
session: string
onSuccess?: () => void
onCancel?: () => void
}

export function DialogSessionRename(props: DialogSessionRenameProps) {
Expand All @@ -18,14 +20,18 @@ export function DialogSessionRename(props: DialogSessionRenameProps) {
<DialogPrompt
title="Rename Session"
value={session()?.title}
onConfirm={(value) => {
sdk.client.session.update({
onConfirm={async (value) => {
await sdk.client.session.update({
sessionID: props.session,
title: value,
})
dialog.clear()
if (props.onSuccess) props.onSuccess()
else dialog.clear()
}}
onCancel={() => {
if (props.onCancel) props.onCancel()
else dialog.clear()
}}
onCancel={() => dialog.clear()}
/>
)
}