feat: configurable message and session limits#177
Open
ariane-emory wants to merge 172 commits intodevfrom
Open
feat: configurable message and session limits#177ariane-emory wants to merge 172 commits intodevfrom
ariane-emory wants to merge 172 commits intodevfrom
Conversation
…roper defaults - Add messages_limit (default: 100) and sessions_list_limit (default: 150) to TUI config - Maintain backward compatibility with existing behavior - Regenerate SDK to include new fields
…onfig documentation
…ne-emory/opencode into feat/configurable-message-limit-wip
Fix race condition where messages_limit config was read before config was loaded from server, causing the default limit of 100 to always be used instead of the user's configured value. The fix tracks sync.ready in the createEffect so it re-runs when the config is fully loaded, ensuring the correct messages_limit is used.
Fix race condition where session_list_limit config was read before config was loaded from server, causing the default limit of 150 to always be used instead of the user's configured value. The fix adds sync.ready check at the start of the options memo so it re-runs when the config is fully loaded, ensuring the correct session_list_limit is used.
The session_list_limit config was not being passed to the server when fetching sessions, so the server always defaulted to 100 sessions. Now fetches config first to get session_list_limit, then passes it as the 'limit' parameter to sdk.client.session.list(). This allows users to see more (or fewer) sessions in the session list dialog.
ariane-emory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces new
tui.messages_limitandtui.session_list_limitconfiguration options allowing the number of message pars displayed in the scrollback and the number of sessions displayed in thesession_listdialogue to be configured using either integral values or the string "none" to display an unlimited number of same.