Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add width: fit-content to a tag #436

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

jacobdalamb
Copy link

Should be default style

Copy link

stackblitz bot commented Nov 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all the formatter changes and update to max-inline-size and I think this is g2g!

src/extra/normalize.src.css Outdated Show resolved Hide resolved
@argyleink argyleink merged commit 43435de into argyleink:main Nov 16, 2023
2 checks passed
@argyleink
Copy link
Owner

need to revert this, caused unexpected side effects for folks wrapping cards or groups of content with a link. i think this needs to go back on the developer to fix when the links are stretching beyond what they need. aka, links needs to be more naive to sizing in normalize, we'll set max-inline-size on links when they're being stretched in undesirable ways.

@jacobdalamb jacobdalamb deleted the chore/update-anchor-tag branch November 22, 2023 21:40
@jacobdalamb jacobdalamb restored the chore/update-anchor-tag branch November 22, 2023 21:40
@jacobdalamb jacobdalamb deleted the chore/update-anchor-tag branch November 22, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants