fix: Remove redundant error message before fatal exception in ErrorReporter #16187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
reviewed
Sep 8, 2025
There was a problem hiding this comment.
The error message is still emitted even though a fatal error is thrown right after. You can have a look at the CI failures to see how and where it manifests. Therefore, although slightly redundant in message, not real redundancy: one is proper logging, the other an exception message.
|
Thank you for submitting the fix and aiming to contribute to Solidity! :) However, I don't believe it adds anything and rather changes existing behavior: where previously there was a warning log message with corresponding error code that 256 errors were exceeded, this is -subject to this PR's changes - no longer emitted. Therefore I am closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.