Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace k8s.io/endpointslice version #582

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

alexmt
Copy link
Contributor

@alexmt alexmt commented Jun 10, 2024

Followup for #566

PR adds replace for k8s.io/endpointslice to fix go list -m -json all command

Signed-off-by: Alexander Matyushentsev <[email protected]>
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.13%. Comparing base (5fd9f44) to head (79bfc25).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   54.71%   55.13%   +0.41%     
==========================================
  Files          41       41              
  Lines        4834     4830       -4     
==========================================
+ Hits         2645     2663      +18     
+ Misses       1977     1953      -24     
- Partials      212      214       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmt alexmt merged commit a9fd001 into argoproj:master Jun 10, 2024
4 checks passed
@alexmt alexmt deleted the replace-k8s-endpoint-slice branch June 10, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants