Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more logging for CRD updates #554

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

crenshaw-dev
Copy link
Member

CRD updates are memory/CPU expensive. If CRDs are changing often, that can cause performance issues. Log changes to help users diagnose performance issues.

Signed-off-by: Michael Crenshaw <[email protected]>
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4a5648e) 54.70% compared to head (e0c2aa0) 54.64%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/cache/cluster.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   54.70%   54.64%   -0.06%     
==========================================
  Files          41       41              
  Lines        4645     4648       +3     
==========================================
- Hits         2541     2540       -1     
- Misses       1908     1911       +3     
- Partials      196      197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit 3de3136 into argoproj:master Apr 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants