feat(trafficrouting): add CanScaleDown hook for traffic router plugins #4598
Conversation
Allow traffic router plugins to delay ReplicaSet scale-down until external systems have completed draining (e.g., long-running connections, worker versioning, message queue consumers). The hook is checked before scaling down: - Intermediate ReplicaSets during interrupted updates (rainbow deployments) - ReplicaSets after scale-down deadline has passed - ReplicaSets when exceeding scaleDownDelayRevisionLimit Signed-off-by: Billy Shambrook <[email protected]>
billyshambrook
force-pushed
the
can-scale-down-hook
branch
from
73380a6 to
0c2aefc
Compare
Published E2E Test Results 4 files 4 suites 3h 25m 44s ⏱️ For more details on these failures, see this check. Results for commit 19f77a0. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 389 tests 2 389 ✅ 3m 10s ⏱️ Results for commit 19f77a0. ♻️ This comment has been updated with latest results. |
- Emit Kubernetes events for errors (matching VerifyWeight pattern) - Remove call-site error logging in favor of centralized event handling - Fix mock ordering for codegen compliance - Fix test fixtures with missing services and action expectations Signed-off-by: Billy Shambrook <[email protected]>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
==========================================
- Coverage 84.37% 84.17% -0.21%
==========================================
Files 164 164
Lines 18845 18948 +103
==========================================
+ Hits 15901 15950 +49
- Misses 2079 2131 +52
- Partials 865 867 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Allow traffic router plugins to delay ReplicaSet scale-down until external systems have completed draining (e.g., long-running connections, worker versioning, message queue consumers).
The hook is checked before scaling down:
... am leaving this ready if the enhancement issue is approved, I already had it coded up so thought I would open the PR now just in case :)
Closes #4597
Checklist:
"fix(controller): Updates such and such. Fixes #1234".