fix(dashboard): avoid dialing 0.0.0.0 in newHTTPServer. Fixes #3931. #4589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Checklist:
"fix(controller): Updates such and such. Fixes #1234".The code declares endpoint with "0.0.0.0:%d", which is eventually passed to RegisterRolloutServiceHandlerFromEndpoint. This in turn calls grpc.Dial, but 0.0.0.0 is not a valid address to pass to a client. This produces one of the errors documented in issue #3931.