Skip to content

Conversation

@ItsMattL
Copy link

Checklist:

  • This is a bugfix
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

The code declares endpoint with "0.0.0.0:%d", which is eventually passed to RegisterRolloutServiceHandlerFromEndpoint. This in turn calls grpc.Dial, but 0.0.0.0 is not a valid address to pass to a client. This produces one of the errors documented in issue #3931.

@ItsMattL ItsMattL changed the title fix (dashboard) avoid dialing 0.0.0.0 in newHTTPServer. Fixes #3931. fix(dashboard): avoid dialing 0.0.0.0 in newHTTPServer. Fixes #3931. Jan 14, 2026
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 26m 1s ⏱️
117 tests 108 ✅  7 💤 2 ❌
470 runs  440 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit 6250ff4.

@github-actions
Copy link
Contributor

Published Unit Test Results

2 372 tests   2 372 ✅  3m 4s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 6250ff4.

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.36%. Comparing base (b9a8811) to head (6250ff4).

Files with missing lines Patch % Lines
server/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4589      +/-   ##
==========================================
- Coverage   84.37%   84.36%   -0.02%     
==========================================
  Files         164      164              
  Lines       18845    18845              
==========================================
- Hits        15901    15899       -2     
- Misses       2079     2080       +1     
- Partials      865      866       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant