Skip to content

Conversation

@krapie
Copy link
Member

@krapie krapie commented Jan 8, 2026

Update experiment template reconciler that If experiment is being retried, check if template RS pod template has changed and delete RS to recreate new RS with new spec.

Fixes: #4578

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Published E2E Test Results

  4 files    4 suites   3h 26m 50s ⏱️
117 tests 108 ✅  7 💤 2 ❌
472 runs  440 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit a88768a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.40%. Comparing base (7518bde) to head (a88768a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4582      +/-   ##
==========================================
+ Coverage   84.36%   84.40%   +0.03%     
==========================================
  Files         164      164              
  Lines       18841    18861      +20     
==========================================
+ Hits        15896    15919      +23     
+ Misses       2079     2078       -1     
+ Partials      866      864       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Published Unit Test Results

2 371 tests   2 371 ✅  3m 4s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit a88768a.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experiments With Same Name & Template Name Doesn't Update the Replica Sets Upon Updates

1 participant