Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default retry configuration for operations triggered via progressive sync strategy #20429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StupidScience
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes #20428

@StupidScience StupidScience requested a review from a team as a code owner October 17, 2024 16:01
Copy link

bunnyshell bot commented Oct 17, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-htdll5.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-htdll5.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.06%. Comparing base (4faf8dd) to head (f2de43d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...cationset/controllers/applicationset_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20429      +/-   ##
==========================================
- Coverage   56.05%   55.06%   -1.00%     
==========================================
  Files         322      322              
  Lines       44802    54916   +10114     
==========================================
+ Hits        25115    30240    +5125     
- Misses      17084    22078    +4994     
+ Partials     2603     2598       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application operation from progressive sync do not have retries by default
1 participant