Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check err before use schedule and duration (#20043) #20371

Open
wants to merge 1 commit into
base: release-2.12
Choose a base branch
from
+264 −75

fix: check err before use schedule and duration (#20043)

703a1ea
Select commit
Loading
Failed to load commit list.
Open

fix: check err before use schedule and duration (#20043) #20371

fix: check err before use schedule and duration (#20043)
703a1ea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 14, 2024 in 0s

50.37% (-0.01%) compared to e2eb54c

View this Pull Request on Codecov

50.37% (-0.01%) compared to e2eb54c

Details

Codecov Report

Attention: Patch coverage is 74.68354% with 20 lines in your changes missing coverage. Please review.

Project coverage is 50.37%. Comparing base (e2eb54c) to head (703a1ea).

Files with missing lines Patch % Lines
server/application/application.go 36.36% 3 Missing and 4 partials ⚠️
controller/sync.go 69.23% 2 Missing and 2 partials ⚠️
pkg/apis/application/v1alpha1/types.go 92.85% 2 Missing and 1 partial ⚠️
cmd/argocd/commands/app.go 66.66% 0 Missing and 2 partials ⚠️
cmd/argocd/commands/projectwindows.go 0.00% 2 Missing ⚠️
server/project/project.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-2.12   #20371      +/-   ##
================================================
- Coverage         50.37%   50.37%   -0.01%     
================================================
  Files               313      313              
  Lines             43167    43203      +36     
================================================
+ Hits              21747    21764      +17     
- Misses            18939    18946       +7     
- Partials           2481     2493      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov