Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add namespaces to resource.exclusions and resource.inclusions #16196 #20286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvandernoort
Copy link

@rvandernoort rvandernoort commented Oct 8, 2024

This PR is the initial work on adding namespaces to the resource exclusion and inclusion system in order to ignore or include them in Argo. Closes #16196

One of the reasons for this functionality is ignoring specific apps that live in a specific namespace, or like some of the automatically generated resources.

However, I'm struggeling with completing this as there are some changes required in the gitops-engine which I'm not sure how to correctly implement or what the process is to get that change into this PR. Could anyone provide me with some assistance on this front?

Furthermore, I think my test suite is still incomplete. Any suggestions as to what should be included for this?

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

initial work on adding namespaces to the resource exclusion and inclusion system in order to ignore or include them in argo

Signed-off-by: Rover van der Noort <[email protected]>
Copy link

bunnyshell bot commented Oct 8, 2024

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@rvandernoort rvandernoort marked this pull request as ready for review October 8, 2024 11:26
@rvandernoort rvandernoort requested a review from a team as a code owner October 8, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource.exclusion with namespace as criteria
1 participant