feat(hydrator): add sourceHydrator types #19536
Draft
+7,981
−1,146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
crenshaw-dev
force-pushed
the
source-hydrator-types
branch
from
79829ec
to
2da30b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19536 +/- ##
=========================================
Coverage ? 56.02%
=========================================
Files ? 322
Lines ? 44723
Branches ? 0
=========================================
Hits ? 25058
Misses ? 17068
Partials ? 2597 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
force-pushed
the
source-hydrator-types
branch
2 times, most recently
from
5a16330
to
84f44f8
Compare
Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Omer Azmon <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Juwon Hwang (Kevin) <[email protected]> Co-authored-by: thisishwan2 <[email protected]> Co-authored-by: mirageoasis <[email protected]> Co-authored-by: Robin Lieb <[email protected]> Co-authored-by: miiiinju1 <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
force-pushed
the
source-hydrator-types
branch
from
84f44f8
to
e97f0ff
Compare
agaudreault
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Document the fields in feature-maturity.md (see #20438)
Other than that, LGTM. Aligned with proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm breaking the hydrator into separate PRs. This is party to make them easier to review, partly because the commit history on the original PR is pretty messy at this point.
This PR just has the new types, i.e. the API, so that it can be reviewed on its own.
I've added everyone who helped as a co-author on this PR.