chore: add tests for utility functions for upsert env & truncate strings

[zhaque44]

This PR adds unit tests for the utils pkg functions:

TruncateString and UpsertEnvironmentStatus

• The TestTruncateString function validates different truncation scenarios, including handling empty, short, and truncated strings, as well as an invalid negative length.
• The TestUpsertEnvironmentStatus function tests the upsert logic for appending new elements, handling empty slices, and managing edge cases with a single element.

[zachaller]

Will need to fix the lint issues, and then also add a new Make target that runs go test but excludes the TestControllers function which could actually probably be renamed to TestControllersGinkgo. Then we would probably need to add the new Make target to the github ci action.

[zhaque44]

and then also add a new Make target that runs go test but excludes the TestControllers function which could actually probably be renamed to TestControllersGinkgo. Then we would probably need to add the new Make target to the github ci action.

@zachaller I dont know my way around this codebase well, can you show me an example of that, I know gingko does that BDD style of tests

[zhaque44]

@zachaller ive updated the func name & created the make target, before adding it to CI, I want to decide on what to name the make target, do you have any suggestions?

[zachaller]

go-unit-test for the make target I think makes sense

[zhaque44]

@zachaller its ready for review

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.45%. Comparing base (a38bb8c) to head (f771974).

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #161       +/-   ##
===========================================
- Coverage   55.10%   37.45%   -17.66%     
===========================================
  Files          10       17        +7     
  Lines        1263     1917      +654     
===========================================
+ Hits          696      718       +22     
- Misses        479     1111      +632     
  Partials       88       88               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zachaller]

The coverage is still broken need to merge reports not sure how because ginkgo doesn't seem to support the new go binary format

[crenshaw-dev]

I wonder if you could do two uploads under different codecov tags, or whatever they call them.

[zachaller]

hm... I would have to look into that guessing its more than just https://github.com/argoproj-labs/gitops-promoter/pull/161/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR53