Skip to content

chore: fix E2E test flake in 1-015-validate-sso-status #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
svghadi merged 1 commit into from
Dec 10, 2025
Merged

chore: fix E2E test flake in 1-015-validate-sso-status #1975

svghadi merged 1 commit into from
Dec 10, 2025

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Dec 10, 2025 •
edited
Loading

What type of PR is this?
/kind chore

What does this PR do / why we need it:

  • Fix an E2E test flake in 1-015, likely due to us not waiting long enough in all cases.

Failing case looks like this:

2025-12-10T08:01:06.6786806Z �[0mGitOps Operator Parallel E2E Tests �[38;5;243m1-015_validate_sso_status �[38;5;9m�[1m[It] ensures that .status field of ArgoCD reflects the expected status based on SSO configuration, and verifies that expected dex resources are created when dex is enabled�[0m
2025-12-10T08:01:06.6789446Z �[38;5;243m/home/runner/work/argocd-operator/argocd-operator/tests/ginkgo/parallel/1-015_validate_sso_status_test.go:56�[0m
2025-12-10T08:01:06.6790166Z 
2025-12-10T08:01:06.6790393Z   �[38;5;243mTimeline >>�[0m
2025-12-10T08:01:06.6791244Z   �[1mSTEP:�[0m creating simple namespace-scoped Argo CD instance �[38;5;243m@ 12/10/25 07:56:36.052�[0m
2025-12-10T08:01:06.6792670Z   �[1mSTEP:�[0m waiting for ArgoCD CR to be reconciled and the instance to be ready, but SSO should be unknown because we haven't defined SSO �[38;5;243m@ 12/10/25 07:56:36.082�[0m
2025-12-10T08:01:06.6793522Z   ArgoCD status is not yet Available
2025-12-10T08:01:06.6794032Z   ArgoCD status is not yet Available
2025-12-10T08:01:06.6794433Z   ArgoCD status is not yet Available
2025-12-10T08:01:06.6795073Z   ArgoCD status is not yet Available
2025-12-10T08:01:06.6795490Z   ArgoCD status is not yet Available
2025-12-10T08:01:06.6795921Z   ArgoCD status is now Available
2025-12-10T08:01:06.6796782Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6797837Z   �[1mSTEP:�[0m updating SSO provider to dex, but not providing any configuration details �[38;5;243m@ 12/10/25 07:57:11.157�[0m
2025-12-10T08:01:06.6799049Z   �[1mSTEP:�[0m verifying Argo CD is pending and SSO is failed, because we have not provided configuration details �[38;5;243m@ 12/10/25 07:57:18.179�[0m
2025-12-10T08:01:06.6799627Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6800104Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6800612Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6800937Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6801233Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6801625Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6801933Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6802500Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6802902Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6803367Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6803868Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6804221Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6804609Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6804925Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6805278Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6805589Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6805977Z   HaveSSOStatus: expected: Failed / actual: Failed
2025-12-10T08:01:06.6806740Z   �[1mSTEP:�[0m verifying dex is not ready for same reason �[38;5;243m@ 12/10/25 07:57:33.196�[0m
2025-12-10T08:01:06.6807265Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6807715Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6808351Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6808757Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6809182Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6809591Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6809972Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6810456Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6810933Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6811312Z   deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6812248Z   �[1mSTEP:�[0m adding a simple placeholder configuration dex config field �[38;5;243m@ 12/10/25 07:57:43.197�[0m
2025-12-10T08:01:06.6813837Z   �[1mSTEP:�[0m verifying Dex and Argo CD start as expected, and are marked as Available and Running, now that we have added a test configuration �[38;5;243m@ 12/10/25 07:57:50.212�[0m
2025-12-10T08:01:06.6814848Z   ArgoCD status is now Available
2025-12-10T08:01:06.6815328Z   HaveSSOStatus: expected: Running / actual: Running
2025-12-10T08:01:06.6816185Z   �[1mSTEP:�[0m verifying dex Deployment is now running �[38;5;243m@ 12/10/25 07:58:00.227�[0m
2025-12-10T08:01:06.6816861Z   Object exists in ExistByName: argocd-dex-server
2025-12-10T08:01:06.6817520Z   Deployment  argocd-dex-server - HaveReadyReplicas: expected:  1 actual:  1
2025-12-10T08:01:06.6818681Z   �[1mSTEP:�[0m verifying other Dex-related resources have been created �[38;5;243m@ 12/10/25 07:58:00.242�[0m
2025-12-10T08:01:06.6819487Z   Object exists in ExistByName: argocd-argocd-dex-server
2025-12-10T08:01:06.6820094Z   Object exists in ExistByName: argocd-argocd-dex-server
2025-12-10T08:01:06.6820647Z   Object exists in ExistByName: argocd-argocd-dex-server
2025-12-10T08:01:06.6821166Z   Object exists in ExistByName: argocd-dex-server
2025-12-10T08:01:06.6822275Z   �[1mSTEP:�[0m removing SSO entirely from ArgoCD CR �[38;5;243m@ 12/10/25 07:58:00.268�[0m
2025-12-10T08:01:06.6823299Z   �[1mSTEP:�[0m verifying ArgoCD status goes back to Unknown SSO status, but Argo CD is still available �[38;5;243m@ 12/10/25 07:58:07.282�[0m
2025-12-10T08:01:06.6823791Z   ArgoCD status is now Available
2025-12-10T08:01:06.6824113Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6824470Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6824813Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6825140Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6825479Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6825813Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6826136Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6826477Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6826825Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6827155Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6827617Z   HaveSSOStatus: expected: Unknown / actual: Unknown
2025-12-10T08:01:06.6827926Z   ArgoCD status is now Available
2025-12-10T08:01:06.6828411Z   ArgoCD status is now Available
2025-12-10T08:01:06.6828658Z   ArgoCD status is now Available
2025-12-10T08:01:06.6828921Z   ArgoCD status is now Available
2025-12-10T08:01:06.6829183Z   ArgoCD status is now Available
2025-12-10T08:01:06.6829428Z   ArgoCD status is now Available
2025-12-10T08:01:06.6829685Z   ArgoCD status is now Available
2025-12-10T08:01:06.6829939Z   ArgoCD status is now Available
2025-12-10T08:01:06.6830181Z   ArgoCD status is now Available
2025-12-10T08:01:06.6830438Z   ArgoCD status is now Available
2025-12-10T08:01:06.6831014Z   �[1mSTEP:�[0m verifying the various dex resources have been deleted �[38;5;243m@ 12/10/25 07:58:47.299�[0m
2025-12-10T08:01:06.6831669Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6832327Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6832966Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6833612Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6834260Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6834904Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6835528Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6836166Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6836803Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6837430Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6838207Z   Object does not exists in ExistByName: argocd-dex-server deployments.apps "argocd-dex-server" not found
2025-12-10T08:01:06.6838910Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6839663Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6840451Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6841179Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6842027Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6842776Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6843518Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6844241Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6844987Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6845729Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6846466Z   Object does not exists in ExistByName: argocd-argocd-dex-server serviceaccounts "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6847291Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6848410Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6849325Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6850226Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6851109Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6852003Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6852903Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6853808Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6854708Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6855607Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6856501Z   Object does not exists in ExistByName: argocd-argocd-dex-server rolebindings.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6857378Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6858367Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6859213Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6860061Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6860910Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6861751Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6862582Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6863499Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6864351Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6865195Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6866027Z   Object does not exists in ExistByName: argocd-argocd-dex-server roles.rbac.authorization.k8s.io "argocd-argocd-dex-server" not found
2025-12-10T08:01:06.6866745Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6867348Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6867940Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6868685Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6869350Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6869981Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6870588Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6871180Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6871768Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6872338Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6872918Z   Object does not exists in ExistByName: argocd-dex-server services "argocd-dex-server" not found
2025-12-10T08:01:06.6873675Z   �[1mSTEP:�[0m enabling keycloak provider, but setting dex config configuration �[38;5;243m@ 12/10/25 07:59:37.619�[0m
2025-12-10T08:01:06.6874441Z   �[1mSTEP:�[0m Argo CD should be Failed/Failed, as this is an invalid configuration �[38;5;243m@ 12/10/25 07:59:44.634�[0m
2025-12-10T08:01:06.6879801Z   HavePhase: expected: Failed / actual: Failed
2025-12-10T08:01:06.6880175Z   HaveSSOStatus: expected: Failed / actual: Failed
2025-12-10T08:01:06.6880722Z   �[1mSTEP:�[0m creating a new SSO secret �[38;5;243m@ 12/10/25 07:59:44.649�[0m
2025-12-10T08:01:06.6881312Z   �[1mSTEP:�[0m updating ArgoCD CR to Dex with a valid client secret �[38;5;243m@ 12/10/25 07:59:44.653�[0m
2025-12-10T08:01:06.6881984Z   �[1mSTEP:�[0m verifying Argo CD becomes available and SSO is running �[38;5;243m@ 12/10/25 07:59:51.671�[0m
2025-12-10T08:01:06.6882569Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6882932Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6883313Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6883642Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6884052Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6884397Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6884896Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6885221Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6885615Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6885923Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6886319Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6886639Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6887111Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6887439Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6887824Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6888462Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6888778Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6889236Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6889563Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6889877Z   HavePhase: expected: Available / actual: Pending
2025-12-10T08:01:06.6890218Z   Deleting Namespace gitops-e2e-test-2584dd8e-e75b
2025-12-10T08:01:06.6891152Z   �[38;5;9m[FAILED]�[0m in [It] - /home/runner/work/argocd-operator/argocd-operator/tests/ginkgo/parallel/1-015_validate_sso_status_test.go:220 �[38;5;243m@ 12/10/25 08:01:06.677�[0m
2025-12-10T08:01:06.6891823Z   �[38;5;243m<< Timeline�[0m
2025-12-10T08:01:06.6891970Z 
2025-12-10T08:01:06.6892138Z   �[38;5;9m[FAILED] Timed out after 60.001s.
2025-12-10T08:01:06.6892406Z   Expected
2025-12-10T08:01:06.6892621Z       <bool>: false
2025-12-10T08:01:06.6892843Z   to be true�[0m
2025-12-10T08:01:06.6893676Z   �[38;5;9mIn �[1m[It]�[0m�[38;5;9m at: �[1m/home/runner/work/argocd-operator/argocd-operator/tests/ginkgo/parallel/1-015_validate_sso_status_test.go:220�[0m �[38;5;243m@ 12/10/25 08:01:06.677�[0m
2025-12-10T08:01:06.6894232Z 
2025-12-10T08:01:06.6894469Z   �[38;5;9mFull Stack Trace�[0m
2025-12-10T08:01:06.6894777Z �[38;5;243m------------------------------�[0m
2025-12-10T08:06:49.0895906Z �[38;5;10m• [342.410 seconds]�[0m

@jgwest jgwest changed the title chore: fix E2E test flak in 1-015-validate-sso-status chore: fix E2E test flake in 1-015-validate-sso-status Dec 10, 2025
@jgwest jgwest mentioned this pull request Dec 10, 2025
Merged
svghadi
svghadi approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@svghadi svghadi merged commit 1264f95 into argoproj-labs:master Dec 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svghadi svghadi svghadi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgwest @svghadi