Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add field to disable/enable metrics #1380

Merged
merged 4 commits into from
May 27, 2024

Conversation

saumeya
Copy link
Collaborator

@saumeya saumeya commented May 27, 2024

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@saumeya saumeya requested review from svghadi and iam-veeramalla May 27, 2024 07:09
@iam-veeramalla
Copy link
Collaborator

@saumeya please run the command make generate manifests bundle to fix the issues with Generated code CI.

Signed-off-by: saumeya <[email protected]>
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Signed-off-by: saumeya <[email protected]>
@saumeya saumeya merged commit a051fbd into argoproj-labs:master May 27, 2024
7 checks passed
reginapizza pushed a commit to reginapizza/argocd-operator that referenced this pull request Jun 5, 2024
* feat: add field to disable/enable metrics

Signed-off-by: saumeya <[email protected]>

* fixes

Signed-off-by: saumeya <[email protected]>

* bundle fix

Signed-off-by: saumeya <[email protected]>

* review changes

Signed-off-by: saumeya <[email protected]>

---------

Signed-off-by: saumeya <[email protected]>
@svghadi svghadi added the backport-to-redesign Changes which need to be backported to operator-redesign branch label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-redesign Changes which need to be backported to operator-redesign branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants