Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [IMPROVEMENT] Add Webhooks delete events with expanded schemas #5519

Draft
wants to merge 1 commit into
base: feat/add-webhooks-feature-branch
Choose a base branch
from

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Sep 19, 2024

Description

Added some changes so we can generate Webhook events before deleting resources and notify those events only after the resource has been successfully deleted.

We need to check some issues that arise with this change.

Refs #1836

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

  • Manually test that deleted resource events are correctly working.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (a65eb96) to head (bf67447).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/add-webhooks-feature-branch    #5519      +/-   ##
====================================================================
+ Coverage                             91.52%   91.53%   +0.01%     
====================================================================
  Files                                   158      159       +1     
  Lines                                  6345     6357      +12     
====================================================================
+ Hits                                   5807     5819      +12     
  Misses                                  538      538              
Flag Coverage Δ
argilla-server 91.53% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant