Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__repr__ implemented for SettingProperties. #5497

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

__repr__ implemented for SettingProperties. #5497

wants to merge 4 commits into from

Conversation

bikash119
Copy link
Contributor

__repr__ implementation for SettingsProperties. This will allow…… use to print human readable representation of Settings

Description

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Executed the unit test using pytest tests/unit

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@bikash119
Added __repr__ implementation for SettingsProperties. This will allow…
2036151 
… use to print human readable representation of Settings
davidberenstein1957
davidberenstein1957 reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also updat the changelog.md?

argilla/tests/unit/test_settings/test_settings.py Outdated Show resolved Hide resolved
@bikash119
1. Updated CHANGELOG.md to include the modifications
0e78d34 
2. Removed a commented code as per the review comments.
davidberenstein1957
davidberenstein1957 reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bikash119, minor comment w.r.t. the changelog : )

argilla/CHANGELOG.md Outdated Show resolved Hide resolved
argilla/CHANGELOG.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] add __repr__ to argilla.settings._resource.SettingsProperties
2 participants
@bikash119 @davidberenstein1957