Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

︷ Custom field with handlebars #5462

Merged

Conversation

damianpumar
Copy link
Contributor

No description provided.

@damianpumar damianpumar self-assigned this Sep 4, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@damianpumar damianpumar changed the base branch from develop to feat/custom-field-support September 4, 2024 21:17
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5462-ki24f765kq-no.a.run.app

@burtenshaw
Copy link
Contributor

@damianpumar should we review and merge this?

@damianpumar
Copy link
Contributor Author

@damianpumar should we review and merge this?

Yes, we can, but I need to change the "mode"

@damianpumar
Copy link
Contributor Author

@burtenshaw could you share with me how can I detect the advanced or basic mode?
Just to apply this little change and merge this PR.

Thanks!

@burtenshaw
Copy link
Contributor

@burtenshaw could you share with me how can I detect the advanced or basic mode? Just to apply this little change and merge this PR.

Thanks!

Hey @damianpumar , the /datasets/{id}/fields endpoint will give this response for custom fields:

{
"id": "51e8fb70-3c3a-4b19-8919-906b28d5c2fd",
"name": "custom",
"title": "custom",
"required": true,
"settings": {
  "type": "custom",
  "template": "<div>{{field}}</div>",
  "advanced_mode": false
},
"dataset_id": "5d9483e5-6f66-4fd6-b56c-54399002f54d",
"inserted_at": "2024-09-26T08:23:42.148948",
"updated_at": "2024-09-26T08:23:42.148948"
}

So you can use advanced_mode as a bool.

@damianpumar
Copy link
Contributor Author

@burtenshaw Thanks!
Now we can merge it, feel free to merge it when you want!

@burtenshaw burtenshaw merged commit ee17b51 into feat/custom-field-support Sep 26, 2024
4 checks passed
@burtenshaw burtenshaw deleted the feat/support-mode-for-custom-field branch September 26, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants