[FEATURE] custom-field-support #5422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s has correct URLs
…ine (#5355) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adds support to indexing datasets and records with image fields. Note: A datasets reindex is required with this change. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - New feature (non-breaking change which adds functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
for more information, see https://pre-commit.ci
…port-to-create-image-fields
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adds support to work with image fields using the SDK. ## TODO (as separate PRs) - [ ] Add documentation section - [ ] Verify behavior using from/to_hub methods - [ ] Add tooling to read data URLs from image files/folders (based on logic defined in `image_to_html`) - [ ] Add some media type validation (supported image types) - [ ] [Optional] Add tooling to re-scale images. The lower the image sizes, the better the UI work. We can define a transparent re-scaling process to support large images (currently the limit size in the backend is 5MB for data URL) **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - New feature (non-breaking change which adds functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: José Francisco Calvo <[email protected]>
Co-authored-by: David Berenstein <[email protected]>
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5422-ki24f765kq-no.a.run.app |
burtenshaw
force-pushed
the
feat/custom-field-support
branch
from
e9e8d9a
to
418699c
Compare
…a-io/argilla into feat/custom-field-support
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
burtenshaw
changed the title
burtenshaw
changed the title
Co-authored-by: José Francisco Calvo <[email protected]>
Co-authored-by: José Francisco Calvo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a custom field on the server and in the SDK.
Server
Fields response is:
{ "items": [ { "id": "11aff30d-e5cf-4485-b646-07adab0bc5b7", "name": "name", "title": "name", "required": true, "settings": { "type": "text", "use_markdown": false }, "dataset_id": "7cccb1e6-9053-4919-b824-43cdb380f7b8", "inserted_at": "2024-08-21T10:47:10.471676", "updated_at": "2024-08-21T10:47:10.471676" }, { "id": "9650009e-e198-40e3-827f-8e0474287fd6", "name": "custom_field", "title": "custom_field", "required": true, "settings": { "type": "custom", "template": "<html></html>" }, "dataset_id": "7cccb1e6-9053-4919-b824-43cdb380f7b8", "inserted_at": "2024-08-21T10:47:10.481962", "updated_at": "2024-08-21T10:47:10.481962" } ] }SDK