-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] [REFACTOR] argilla-server
: move search logic to search service
#5174
Draft
frascuchon
wants to merge
14
commits into
refactor/argilla-server/list-records-endpoint-using-db
Choose a base branch
from
refactor/argilla-server/move-search-logic-to-search-service
base: refactor/argilla-server/list-records-endpoint-using-db
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation logic there
… into refactor/argilla-server/move-search-validator-to-proper-module
…-module' into refactor/argilla-server/move-search-logic-to-search-service
frascuchon
changed the base branch from
refactor/argilla-server/move-search-validator-to-proper-module
to
refactor/argilla-server/list-records-endpoint-using-db
July 19, 2024 06:59
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/argilla-server/list-records-endpoint-using-db #5174 +/- ##
==========================================================================================
- Coverage 91.22% 91.09% -0.14%
==========================================================================================
Files 142 144 +2
Lines 5746 5793 +47
==========================================================================================
+ Hits 5242 5277 +35
- Misses 504 516 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frascuchon
added
the
type: refactor
Indicates internal refactoring of the code-base
label
Jul 19, 2024
… into refactor/argilla-server/move-search-logic-to-search-service
… into refactor/argilla-server/move-search-logic-to-search-service
… into refactor/argilla-server/move-search-logic-to-search-service
frascuchon
changed the title
[REFACTOR]
[DRAFT] [REFACTOR] Sep 9, 2024
argilla-server
: move search logic to search serviceargilla-server
: move search logic to search service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans and moves all logic from search endpoint handlers to a Search service.
Update
The code will probably be moved to under the search context module.
Type of change
How Has This Been Tested
Checklist