🎯 poc/string length #5001
Open
🎯 poc/string length #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
damianpumar
commented
Jun 12, 2024
damianpumar
commented
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5001-ki24f765kq-no.a.run.app |
jfcalvo
reviewed
Jun 14, 2024
| @@ -0,0 +1,12 @@ | |||
| def jslen(string): | |||
| return int(len(string.encode(encoding='utf_16_le'))/2) | |||
There was a problem hiding this comment.
My only concern is that I don't understand why we need to specify the encoding to be utf_16_le when we are using utf-8 for everything.
There was a problem hiding this comment.
Also, the problem to solve is to keep aligned string lengths between python and javascript. Spans boundaries are defined in python, and probably will be processed in python. We need to ensure that the same piece of text will be processed in both python and javascript. Here is an article about span processing
There was a problem hiding this comment.
Hi team, this feat does not work with utf 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.