Apply proper serializer when pushing feedback dataset in Argilla #3192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, the
model.dict()
method won't apply custom serialization to theUUID
ordatetatime
fields. Since pydantic provides a.json
method which applies serialization properly, we should use them in order to support pushing data in Argilla.The current solution may be improved since we're serializing more times than needed. But for that, we should change the sdk.v1.api layer. See issue #3191
Closes #3189
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)New tests have been added
Checklist