Merge pull request #127 from arethetypeswrong/bug/125

Fix TypeScript error for unresolved reference to ts-expose-internals

.changeset/khaki-actors-tickle.md

@@ -0,0 +1,5 @@
+---
+"@arethetypeswrong/core": patch
+---
+
+Fix TypeScript error for unresolved reference to ts-expose-internals

.github/workflows/ci.yml

@@ -31,3 +31,4 @@ jobs:
       - run: pnpm tsc
       - run: pnpm build
       - run: pnpm test
+      - run: pnpm check-dts

.github/workflows/version-or-publish.yml

@@ -38,6 +38,7 @@ jobs:
       - run: pnpm install
       - run: pnpm build
       - run: pnpm test
+      - run: pnpm check-dts
       - uses: changesets/action@v1
         with:
           publish: pnpm changeset publish

package.json

@@ -11,16 +11,22 @@
     "build": "pnpm tsc && pnpm -r build",
     "format": "prettier --write \"**/*.{ts,json,css}\"",
     "test": "pnpm -r test",
+    "check-dts": "tsc -p tsconfig.check-dts.json",
     "start": "pnpm --filter @arethetypeswrong/web start",
     "version": "changeset version && pnpm install --lockfile-only"
   },
   "devDependencies": {
     "@changesets/cli": "^2.27.1",
     "prettier": "^3.0.3",
-    "typescript": "5.3.2"
+    "typescript": "5.3.3"
   },
   "engines": {
     "node": ">=18",
     "pnpm": ">=8"
+  },
+  "pnpm": {
+    "overrides": {
+      "ts-expose-internals-conditionally": "$typescript"
+    }
   }
 }

packages/core/package.json

@@ -50,14 +50,14 @@
     "@andrewbranch/untar.js": "^1.0.3",
     "fflate": "^0.7.4",
     "semver": "^7.5.4",
-    "typescript": "5.3.2",
+    "ts-expose-internals-conditionally": "1.0.0-empty.0",
+    "typescript": "5.3.3",
     "validate-npm-package-name": "^5.0.0"
   },
   "devDependencies": {
     "@types/node": "^20.8.6",
     "@types/semver": "^7.5.0",
-    "@types/validate-npm-package-name": "^4.0.0",
-    "ts-expose-internals": "5.3.2"
+    "@types/validate-npm-package-name": "^4.0.0"
   },
   "engines": {
     "node": ">=18"

packages/core/test/snapshots/moment@2.29.1.tgz.json

@@ -30,7 +30,7 @@
               "File '/node_modules/moment.d.ts' does not exist.",
               "'package.json' has a 'typesVersions' field with version-specific path mappings.",
               "'package.json' has 'typings' field './moment.d.ts' that references '/node_modules/moment/moment.d.ts'.",
-              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.2', looking for a pattern to match module name 'moment.d.ts'.",
+              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.3', looking for a pattern to match module name 'moment.d.ts'.",
               "Module name 'moment.d.ts', matched pattern '*'.",
               "Trying substitution 'ts3.1-typings/*', candidate module location: 'ts3.1-typings/moment.d.ts'.",
               "File '/node_modules/moment/ts3.1-typings/moment.d.ts' exists - use it as a name resolution result.",
@@ -63,7 +63,7 @@
               "File '/node_modules/moment.d.ts' does not exist.",
               "'package.json' has a 'typesVersions' field with version-specific path mappings.",
               "'package.json' has 'typings' field './moment.d.ts' that references '/node_modules/moment/moment.d.ts'.",
-              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.2', looking for a pattern to match module name 'moment.d.ts'.",
+              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.3', looking for a pattern to match module name 'moment.d.ts'.",
               "Module name 'moment.d.ts', matched pattern '*'.",
               "Trying substitution 'ts3.1-typings/*', candidate module location: 'ts3.1-typings/moment.d.ts'.",
               "File '/node_modules/moment/ts3.1-typings/moment.d.ts' exists - use it as a name resolution result.",
@@ -92,7 +92,7 @@
               "Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
               "File '/node_modules/moment/package.json' exists according to earlier cached lookups.",
               "'package.json' has 'typings' field './moment.d.ts' that references '/node_modules/moment/moment.d.ts'.",
-              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.2', looking for a pattern to match module name 'moment.d.ts'.",
+              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.3', looking for a pattern to match module name 'moment.d.ts'.",
               "Module name 'moment.d.ts', matched pattern '*'.",
               "Trying substitution 'ts3.1-typings/*', candidate module location: 'ts3.1-typings/moment.d.ts'.",
               "File '/node_modules/moment/ts3.1-typings/moment.d.ts' exists - use it as a name resolution result.",
@@ -125,7 +125,7 @@
               "File '/node_modules/moment.d.ts' does not exist.",
               "'package.json' has a 'typesVersions' field with version-specific path mappings.",
               "'package.json' has 'typings' field './moment.d.ts' that references '/node_modules/moment/moment.d.ts'.",
-              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.2', looking for a pattern to match module name 'moment.d.ts'.",
+              "'package.json' has a 'typesVersions' entry '>=3.1' that matches compiler version '5.3.3', looking for a pattern to match module name 'moment.d.ts'.",
               "Module name 'moment.d.ts', matched pattern '*'.",
               "Trying substitution 'ts3.1-typings/*', candidate module location: 'ts3.1-typings/moment.d.ts'.",
               "File '/node_modules/moment/ts3.1-typings/moment.d.ts' exists - use it as a name resolution result.",

packages/core/tsconfig.json

@@ -10,7 +10,8 @@
     "module": "nodenext",
     "outDir": "dist",
     "rootDir": "src",
-    "types": ["ts-expose-internals"]
+    "types": ["ts-expose-internals-conditionally"],
+    "customConditions": ["ts-expose-internals"]
   },
   "include": ["src"]
 }

packages/history/package.json

@@ -47,10 +47,10 @@
     "npm-high-impact": "^1.3.0",
     "pacote": "^15.2.0",
     "semver": "^7.5.3",
-    "ts-expose-internals": "5.3.2",
+    "ts-expose-internals": "5.3.3",
     "tsx": "^3.12.7",
     "types-registry": "latest",
-    "typescript": "5.3.2"
+    "typescript": "5.3.3"
   },
   "engines": {
     "node": ">=18"

tsconfig.check-dts.json

@@ -0,0 +1,8 @@
+{
+  "compilerOptions": {
+    "module": "nodenext",
+    "noEmit": true,
+    "strict": true
+  },
+  "include": ["./packages/core/dist"]
+}